Minor quality of life improvements #12952
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of warnings during compilation has increased recently. This PR attempts to ignore/fix some of them, so that we don't miss the important stuff.
hubertp
requested review from
radeusgd,
jdunkerley,
GregoryTravis,
AdRiley,
marthasharkey,
4e6,
JaroslavTulach and
Akirathan
as code owners
hubertp
added
the
CI: No changelog needed
AdRiley
approved these changes
Apr 25, 2025
jdunkerley
approved these changes
Apr 25, 2025
GregoryTravis
approved these changes
Apr 25, 2025
| } catch (InterruptedException e) { | ||
| System.out.println( | ||
| "Server main thread was unexpectedly interrupted. The server will now stop."); | ||
| System.in.read(); |
There was a problem hiding this comment.
I have always wished that pressing return did not quit the server...
There was a problem hiding this comment.
I can check for a specific keyword :p
In all seriousness, I'm not sure what is a better alternative for this testing tool?
GregoryTravis
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The number of warnings during compilation has increased recently. This PR attempts to ignore/fix some of them, so that we don't miss the important stuff.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.