Add hyper write support #12900
Open
Add hyper write support #12900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdRiley
force-pushed
the
wip/adr/add-hyper-write
branch
from
3120fe9 to
9e1af90
Compare
AdRiley
requested review from
jdunkerley,
radeusgd,
GregoryTravis and
marthasharkey
as code owners
AdRiley
requested review from
Frizi,
farmaazon,
vitvakatu,
kazcw,
PabloBuchu,
indiv0,
somebody1234 and
MrFlashAccount
as code owners
AdRiley
force-pushed
the
wip/adr/add-hyper-write
branch
from
2a5b700 to
3cf0024
Compare
AdRiley
removed request for
indiv0,
Frizi,
kazcw,
PabloBuchu,
farmaazon,
somebody1234,
vitvakatu and
MrFlashAccount
| Implements the `Table.write` for this `File_Format`. | ||
| write_table self file:Writable_File table:Table on_existing_file match_columns:Match_Columns on_problems:Problem_Behavior = | ||
| _ = [match_columns, on_problems] | ||
| if (on_existing_file == Existing_File_Behavior.Append) then Error.throw (Illegal_Argument.Error "Writing to hyper files is not yet supported.") else |
There was a problem hiding this comment.
Suggested change
| if (on_existing_file == Existing_File_Behavior.Append) then Error.throw (Illegal_Argument.Error "Writing to hyper files is not yet supported.") else | |
| if (on_existing_file == Existing_File_Behavior.Append) then Error.throw (Illegal_Argument.Error "Appending to hyper files is not yet supported.") else |
?
GregoryTravis
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Adds support for writing to tableau hyper files.
Defaults to Extract Extract
Or can set schema and table name by using explicit format
Appending currently not supported, but will be added as follow on.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.