Fix Meta.enso_project #10192
Fix Meta.enso_project #10192
Conversation
Akirathan
added
the
CI: No changelog needed
Akirathan
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
AdRiley,
marthasharkey,
4e6,
JaroslavTulach and
hubertp
as code owners
| src.take (Last loc.length) . should_equal loc | ||
|
|
||
| group_builder.specify "should allow to get qualified type names of values" <| | ||
| x = 42 | ||
| y = My_Type.Value 1 2 3 | ||
| Meta.get_qualified_type_name x . should_equal "Standard.Base.Data.Numbers.Integer" | ||
| Meta.get_simple_type_name x . should_equal "Integer" | ||
| Meta.get_qualified_type_name y . should_equal "enso_dev.Base_Tests.Semantic.Meta_Location_Spec.My_Type" | ||
| Meta.get_qualified_type_name y . should_end_with "Meta_Location_Spec.My_Type" |
There was a problem hiding this comment.
Unrelated change. It ensures that one can run this test as standalone with enso --run test/Base_Tests/src/Semantic/Meta_Location_Spec.enso
There was a problem hiding this comment.
Won't the tests below break if run without --in-project anyway?
There was a problem hiding this comment.
There is no need to specify --in-project anymore since #8775
There was a problem hiding this comment.
So why was the standalone run ever failing? It should always return enso_dev.Base_Tests.Semantic.Meta_Location_Spec.My_Type as the qualified name, no?
If not, what does it return instead??
There was a problem hiding this comment.
If not, what does it return instead??
It incorrectly returns Meta_Location_Spec.My_Type.
Meta.get_qualified_type_name seems broken. Tracked in #10228. In that issue, there is a task to revert this change once that is fixed.
Akirathan
added
the
CI: Clean build required
Fixes #9845
Pull Request Description
Fixes
Standard.Base.Meta.Enso_Project.enso_projectto return a project descriptor for the main project, i.e., the one configured as a root for the engine.Important Notes
enso_projectbuiltin no longer iterates the stack frames to infer the project descriptor. It derives it from the default package repository.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.