-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use context-based role assignments to implement the permission model #19
base: main
Are you sure you want to change the base?
feat: use context-based role assignments to implement the permission model #19
Conversation
Pull Request Test Coverage Report for Build 13712517344Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…even when user-facing token id is re-generated
* | ||
* See v1 fuse: CAN_EXTEND_EXPIRY | ||
*/ | ||
function allowOwnerToRenew(uint256 tokenId) public onlyRole(_tokenIdContext(tokenId), EMANCIPATOR_ROLE) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that if you emancipate a name, it's no longer possible to grant the owner permission to renew it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because in the name wrapper, once you emancipate you can no longer burn any other fuses on it. That was my interpretation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parent owner cannot - but if I'm reading this correctly, the emancipated owner cannot renew either!
feat: add _transferRole method
@Arachnid Given that we only need to transfer two roles to a new registrar (registrar and renew) I felt that it was easier to do that manually whilst keeping the current storage approach in Plus, role transfers only work across a particular context. There's no way to transfer all of a user's roles in all contexts. I suppose if we implement hierarchical contexts of some sort we could perhaps do this. But again, this complicates the access control storage. Happy to discuss this further over calls. |
…rom one account to another
Notes: