Expanding contract interfaces template, filled out for resolver page #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serenae-fansubs
requested review from
lucemans,
svemat01 and
gskril
as code owners
Deploying ens-docs with
|
| Latest commit: |
41ac72a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6fee47b2.docs-bao.pages.dev |
| Branch Preview URL: | https://feat-resolver-interfaces.docs-bao.pages.dev |
|
@lucemans The build check is failing, but I think that's due to something unrelated to this PR: |
lucemans
force-pushed
the
feat/resolver-interfaces
branch
from
de8b016
to
41ac72a
Compare
|
Rebased, going to test CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic interface templating moved to
interfaces.tsx. Each contract/interface page just needs to callinterfaceDetails.Added
ContractParameter, where both inputs and outputs can be specified. Each parameter/result can have its own specific description.The
seeMorefield will automatically have EIP/ENSIP keys turned into links.A new
examplesfield can be used to show usage examples for methods.And other small tweaks.