Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing four new proposals to the repo: 5.9, 5.10, 5.11, 5.12 #267

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

estmcmxci
Copy link
Contributor

Introducing four new proposals to the repo: 5.9, 5.10, 5.11, 5.12

Issue #266

#266

Copy link
Member

@gskril gskril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

Looks like there are some mismatches between this PR and the live proposals. Also, please add these new links to the sidebar here so they show up on https://docs.ens.domains/dao

docs/dao/proposals/5.10.mdx Outdated Show resolved Hide resolved
docs/dao/proposals/5.9.mdx Outdated Show resolved Hide resolved
docs/dao/proposals/5.12.mdx Show resolved Hide resolved
@estmcmxci
Copy link
Contributor Author

Thanks for contributing!

Looks like there are some mismatches between this PR and the live proposals. Also, please add these new links to the sidebar here so they show up on https://docs.ens.domains/dao

All done, committing and pushing now.

Copy link
Member

@gskril gskril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metadata wasn't updated for EP 5.12. Otherwise looking good!

docs/dao/proposals/5.12.mdx Outdated Show resolved Hide resolved
docs/dao/proposals/5.12.mdx Outdated Show resolved Hide resolved
Copy link
Member

@lucemans lucemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucemans lucemans merged commit cb94af3 into ensdomains:master Aug 27, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants