Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ENS-Contracts-Overview.md #168

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

h1utt
Copy link
Contributor

@h1utt h1utt commented Jan 24, 2024

Reformat capital letters

Reformat capital letters
Copy link
Member

@lucemans lucemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucemans lucemans merged commit 6029f9c into ensdomains:master Jan 25, 2024
* **DNS Oracle (dnssec.ens.eth)**: This oracle performs a CCIP read on a given DNS name and grants the owner. To learn more read [Secure offchain data retrieval Standard](https://eips.ethereum.org/EIPS/eip-3668)
* **Reverse Registrar (addr.reverse)** This reverse registrar allows an account to set their primary name.
* **Reverse Registrar (addr.reverse)**: This reverse registrar allows an account to set their primary name.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.



Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

* **The Root control (root.ens.eth)**: This is a simple access control for the root. It serves as an interface for the ENS registry, except it also allows some names to be locked. Once locked the owner cannot unlocked it. At the time of this writing, only .eth was locked, and since this contract doesn't allow to transfer ownership of the root node itself, it means that the .eth registrar is now forever locked on the main registry. The owner of the root contract is set as the multisig.ens.eth.
* **The Multisig (multisig.ens.eth)**: This is a group of 7 keyholders who were initially charged with the responsibility of managing most of ENS aspects. With the launch of the ENS DAO, most of these responsibilites are slowly being transferred away, but as requested by EP1, the root ownership still belongs to them.
* **.ETH Registrar (registrar.ens.eth)**: This is an ERC721 compatible contract, and is the address ENS users will likely add to their wallets to see their domains as NFTs. Transferring an NFT will not automatically update the ownership on the Registry, but allows the NFT owner to call the "claim()" function which will update the registry on their behalf. This contract allows its owner (currently set as the DAO) to add and remove controllers, as well as change ownership of the registrar. Metadata for the NFTs are not set in the contract, but at stored at the metadata.ens.domains service.
* **DNS Registrar (dnsregistrar.ens.eth)**: This contract owns mosts TLDs recognized by ICANN and use DNSSec to update these names.
* **DNS Oracle (dnssec.ens.eth)**: This oracle performs a CCIP read on a given DNS name and grants the owner. To learn more read [Secure offchain data retrieval Standard](https://eips.ethereum.org/EIPS/eip-3668)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • DNS Oracle (dnssec.ens.eth):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

**

* **DNS Oracle (dnssec.ens.eth)**: This oracle performs a CCIP read on a given DNS name and grants the owner. To learn more read [Secure offchain data retrieval Standard](https://eips.ethereum.org/EIPS/eip-3668)
* **Reverse Registrar (addr.reverse)** This reverse registrar allows an account to set their primary name.
* **Reverse Registrar (addr.reverse)**: This reverse registrar allows an account to set their primary name.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **Reverse Registrar (addr.reverse)**: This reverse registrar allows an account to set their primary name.
* **Reverse Registrar (addr.reverse)**: This reverse registrar allows an account to set their primary name.

* **The Multisig (multisig.ens.eth)** This is a group of 7 keyholders who were initially charged with the responsibility of managing most of ENS aspects. With the launch of the ENS DAO, most of these responsibilites are slowly being transferred away, but as requested by EP1, the root ownership still belongs to them.
* **.ETH Registrar (registrar.ens.eth)** This is an ERC721 compatible contract, and is the address ENS users will likely add to their wallets to see their domains as NFTs. Transferring an NFT will not automatically update the ownership on the Registry, but allows the NFT owner to call the "claim()" function which will update the registry on their behalf. This contract allows its owner (currently set as the DAO) to add and remove controllers, as well as change ownership of the registrar. Metadata for the NFTs are not set in the contract, but at stored at the metadata.ens.domains service.
* **DNS Registrar (dnsregistrar.ens.eth)** This contract owns mosts TLDs recognized by ICANN and use DNSSec to update these names.
* **The Root control (root.ens.eth)**: This is a simple access control for the root. It serves as an interface for the ENS registry, except it also allows some names to be locked. Once locked the owner cannot unlocked it. At the time of this writing, only .eth was locked, and since this contract doesn't allow to transfer ownership of the root node itself, it means that the .eth registrar is now forever locked on the main registry. The owner of the root contract is set as the multisig.ens.eth.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **The Root control (root.ens.eth)**: This is a simple access control for the root. It serves as an interface for the ENS registry, except it also allows some names to be locked. Once locked the owner cannot unlocked it. At the time of this writing, only .eth was locked, and since this contract doesn't allow to transfer ownership of the root node itself, it means that the .eth registrar is now forever locked on the main registry. The owner of the root contract is set as the multisig.ens.eth.
* **The Root control (root.ens.eth)**: This is a simple access control for the root. It serves as an interface for the ENS registry, except it also allows some names to be locked. Once locked the owner cannot unlocked it. At the time of this writing, only .eth was locked, and since this contract doesn't allow to transfer ownership of the root node itself, it means that the .eth registrar is now forever locked on the main registry. The owner of the root contract is set as the multisig.ens.eth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants