Adds create, update, delete of a schedule and a job scheduling at once #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manages both job and schedule references removal.
These methods are intended to provide simple JobSchedule operations with consistent naming. Job and schedule concepts are managed all at once.
Warning: Don't know if version name change is wise. Use to publish-local artifact to test integration in other projects.
|
Hi @refond , I managed to get around to reviewing this. Overall, it looks good. Can you add a section to the README.md explaining how to use these functions so that newcomers to the library know to use them? |
|
Hi @enragedginger, great to read it looks good to you. Of course I will add section to the README.md with explanations, examples. I just won't I have time to do it before the second week of January. |
|
Hi @enragedginger, finally added a section to the README.md file explaining how to use these new functions. |
|
I would be very interested in this functionality, any changes to get a new release in the next days? |
enragedginger
approved these changes
Feb 8, 2019
|
@qux42 This has been published as build |
kvma
pushed a commit
to kvma/akka-quartz-scheduler
that referenced
this pull request
Sep 16, 2019
enragedginger#81) * Adds new unscheduleJob method. Manages both job and schedule references removal. * Add public create, update, delete methods on JobSchedule. These methods are intended to provide simple JobSchedule operations with consistent naming. Job and schedule concepts are managed all at once. * Removed unnecessary comments. Warning: Don't know if version name change is wise. Use to publish-local artifact to test integration in other projects. * Fix wrong @return documentation. * WIP - updateJobSchedule and deleteJobSchedule tests fails. * Fix test cron expressions to match expected result. All tests pass! * Typo * Add test for non existing job schedule deletion. * Remove test artifact version modification. * Added usage Dynamic create, update, delete `JobSchedule` operations sub-section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following new public methods to QuartzSchedulerExtension`:
createJobScheduleupdateJobScheduledeleteJobScheduleakaunscheduleJobThey mostly build upon existing methods in order to manage a schedule and its associated job in a single call.
The ability to perform the removal of an existing schedule together with job cancellation is the only new behaviour added to the QuartzSchedulerExtension by the mean of
unscheduleJob.createJobSchedulebuilds upon existingcreateScheduleandschedulemethods.updateJobScheduleis a synonym to existingrescheduleJobmethod.deleteJobScheduleis a synonym to the newunscheduleJobmethod.unscheduleJobbuilds upon existingcancelJoband privateremoveSchedulemethods.