Skip to content

Conversation

@vorburger
Copy link
Member

Relates to #1862.

Is expected to fail on CI until that issue is fixed.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the project's test suite by adding a new CLI integration test. The primary goal is to increase coverage for the MCP component and proactively identify regressions linked to a known issue, #1862. While the test is designed to fail initially due to the unresolved issue, its inclusion sets the stage for improved stability once the underlying problem is addressed.

Highlights

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new CLI integration test for MCP, which is a great step towards preventing regressions. The changes correctly add the test and configure it to run only on CI. I have a couple of suggestions to improve the CI workflow and a minor one for comment clarity.

@vorburger
Copy link
Member Author

Related to modelcontextprotocol/java-sdk#605.

The cause of the NPE is clear when run with #1900 so that modelcontextprotocol/java-sdk#607 for modelcontextprotocol/java-sdk#605 is used.

@vorburger
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces valuable integration test coverage for the MCP CLI, which is a great step towards ensuring stability and preventing regressions like the one mentioned in issue #1862. The changes are well-thought-out, including creating a dedicated test script, updating the CI configuration to execute it, and cleverly using an echo model in the test agent to remove external dependencies. The documentation has also been updated accordingly. I have a couple of minor suggestions to improve the clarity of paths in the documentation's code examples.

@vorburger vorburger enabled auto-merge (rebase) November 8, 2025 22:49
@vorburger vorburger merged commit b7d34d3 into enola-dev:main Nov 8, 2025
14 checks passed
@vorburger vorburger deleted the test-mcp branch November 8, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant