-
Notifications
You must be signed in to change notification settings - Fork 13
test: Add CLI integration test coverage for MCP #1903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's test suite by adding a new CLI integration test. The primary goal is to increase coverage for the MCP component and proactively identify regressions linked to a known issue, #1862. While the test is designed to fail initially due to the unresolved issue, its inclusion sets the stage for improved stability once the underlying problem is addressed. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new CLI integration test for MCP, which is a great step towards preventing regressions. The changes correctly add the test and configure it to run only on CI. I have a couple of suggestions to improve the CI workflow and a minor one for comment clarity.
|
Related to modelcontextprotocol/java-sdk#605. The cause of the NPE is clear when run with #1900 so that modelcontextprotocol/java-sdk#607 for modelcontextprotocol/java-sdk#605 is used. |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces valuable integration test coverage for the MCP CLI, which is a great step towards ensuring stability and preventing regressions like the one mentioned in issue #1862. The changes are well-thought-out, including creating a dedicated test script, updating the CI configuration to execute it, and cleverly using an echo model in the test agent to remove external dependencies. The documentation has also been updated accordingly. I have a couple of minor suggestions to improve the clarity of paths in the documentation's code examples.
Relates to #1862.
Is expected to fail on CI until that issue is fixed.