Skip to content

Conversation

@vorburger
Copy link
Member

@vorburger vorburger commented Aug 19, 2025

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the capability to configure the logging level for each Model Context Protocol (MCP) server connection. Previously, the logging level was hardcoded, but now it can be specified per server, allowing for more granular control over the verbosity of logs.

Highlights

  • Configurable Logging Level: The McpSyncClient now accepts a McpSchema.LoggingLevel parameter, enabling dynamic setting of the logging level for MCP server connections.
  • Default Logging Level: A new log field of type McpSchema.LoggingLevel has been added to the McpServerConnectionsConfig.Server class, defaulting to WARNING, allowing individual server configurations to specify their desired logging verbosity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable feature for configuring the logging level on a per-server basis. The implementation is correct and follows the existing structure. I've provided two suggestions to enhance code quality: one to avoid a redundant map lookup for better performance and maintainability, and another to improve the clarity of a new configuration property's name.

@vorburger vorburger merged commit 538a4ed into enola-dev:main Aug 19, 2025
9 checks passed
@vorburger vorburger deleted the mcp-logging-configurable branch August 19, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant