Skip to content

Comments

devop: remove survey#759

Merged
kvhnuke merged 1 commit intodevop/release-v-2-13from
devop/remove-survey
Sep 25, 2025
Merged

devop: remove survey#759
kvhnuke merged 1 commit intodevop/release-v-2-13from
devop/remove-survey

Conversation

@gamalielhere
Copy link
Contributor

@gamalielhere gamalielhere commented Sep 24, 2025

Summary by CodeRabbit

  • Chores
    • Removed the in-app survey popup from the app menu. Users will no longer see survey prompts here, including after dismissing the Solana staking banner. This reduces interruptions and streamlines navigation. No action is required from users. Preferences and existing features remain unchanged, with no impact on performance or stability.

@coderabbitai
Copy link

coderabbitai bot commented Sep 24, 2025

Walkthrough

The app-menu component in packages/extension/src/ui/action/components/app-menu/index.vue removes the SurveyPopup feature, including its import, state refs, open/close handlers, and the invocation tied to closing the Solana staking banner. The template no longer renders the survey popup, leaving a placeholder comment.

Changes

Cohort / File(s) Summary of Changes
UI: Remove Survey Popup from App Menu
packages/extension/src/ui/action/components/app-menu/index.vue
Deleted SurveyPopup import; removed isSurveyPopup ref and openSurveyPopup/closeSurveyPopup methods; removed call from closeSolanaStakingBanner; replaced <survey-popup> template usage with a placeholder comment; no external API changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant AppMenu
  participant SolanaStakingBanner

  Note over AppMenu: Old flow (before change)
  User->>AppMenu: Close Solana staking banner
  AppMenu->>SolanaStakingBanner: close()
  AppMenu->>AppMenu: openSurveyPopup()

  Note over AppMenu: New flow (after change)
  User->>AppMenu: Close Solana staking banner
  AppMenu->>SolanaStakingBanner: close()
  Note over AppMenu: No survey popup triggered
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • NickKelly1

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title concisely conveys the primary change by stating the removal of the survey functionality, which matches the deletion of the SurveyPopup component and related logic in the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devop/remove-survey

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

💼 Build Files
chrome: enkrypt-chrome-85f9c49d.zip
firefox: enkrypt-firefox-85f9c49d.zip

💉 Virus total analysis
chrome: 85f9c49d
firefox: 85f9c49d

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
packages/extension/src/ui/action/components/app-menu/index.vue (1)

281-285: Remove dangling openSurveyPopup() call in app-menu/index.vue
openSurveyPopup() was removed and is now undefined—delete the block:

-  if (!isSolanaStakingBanner.value) {
-    openSurveyPopup();
-  }
🧹 Nitpick comments (1)
packages/extension/src/ui/action/components/app-menu/index.vue (1)

168-174: Remove commented-out survey markup.

If the goal is full removal, drop the commented survey block to avoid rot.

Apply this diff:

-      <!-- Leaving this here for future use -->
-      <!-- <survey-popup
-        v-else-if="isSurveyPopup && isExpanded"
-        key="survey-popup"
-        @close="closeSurveyPopup"
-      /> -->
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3f5aab and 85f9c49.

📒 Files selected for processing (1)
  • packages/extension/src/ui/action/components/app-menu/index.vue (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: buildAll
  • GitHub Check: test
  • GitHub Check: test

@kvhnuke kvhnuke changed the base branch from develop to devop/release-v-2-13 September 25, 2025 18:50
@kvhnuke kvhnuke merged commit 8399873 into devop/release-v-2-13 Sep 25, 2025
5 checks passed
@kvhnuke kvhnuke deleted the devop/remove-survey branch September 25, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants