feat: add TAC mainnet#745
Conversation
WalkthroughAdds TAC as a new EVM network: defines a TAC network configuration, registers it in the Ethereum networks index, and adds Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Wallet
participant NetworksIndex as "Networks Index"
participant TAC as "EvmNetwork: TAC"
participant Assets as "assetsInfoHandler"
participant Activity as "wrapActivityHandler(EtherscanActivity)"
User->>Wallet: Choose TAC network / view account
Wallet->>NetworksIndex: Resolve network by name (TAC)
NetworksIndex->>TAC: Return TAC network config
Wallet->>TAC: Request assets
TAC->>Assets: Fetch assets metadata
Assets-->>TAC: Return assets metadata
TAC-->>Wallet: Provide assets
User->>Wallet: Request activity
Wallet->>TAC: Fetch activity
TAC->>Activity: Query Etherscan-compatible API
Activity-->>TAC: Return activity list
TAC-->>Wallet: Provide activity
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
packages/extension/src/providers/ethereum/networks/index.ts(2 hunks)packages/extension/src/providers/ethereum/networks/tac.ts(1 hunks)packages/types/src/networks.ts(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
packages/extension/src/providers/ethereum/networks/tac.ts (2)
packages/extension/src/providers/ethereum/types/evm-network.ts (2)
EvmNetworkOptions(22-53)EvmNetwork(55-286)packages/extension/src/providers/ethereum/libs/activity-handlers/index.ts (1)
EtherscanActivity(10-10)
🔇 Additional comments (6)
packages/types/src/networks.ts (1)
115-116: Enum entry looks goodAdding
TACtoNetworkNamesis consistent with the new network integration.packages/extension/src/providers/ethereum/networks/index.ts (1)
81-82: Registry wiring is correctImport and export of
tacfollow existing patterns; no issues spotted.Also applies to: 172-173
packages/extension/src/providers/ethereum/networks/tac.ts (4)
18-18: RPC endpoint is valid
https://rpc.ankr.com/tacis an official TAC RPC on Ankr. No change needed. (ankr.com)
1-1: Icon asset present. Verifiedpackages/extension/src/providers/ethereum/networks/icons/tac.webpexists and matches the import path.
12-13: Explorer APIs confirmed
Bothhttps://tac.blockscout.com/apiandhttps://explorer.tac.build/apireturn HTTP 200 for themodule=account&action=txlistEtherscan-style request, confirming API compatibility for the activity handler.
20-23: No changes needed for missingcoingeckoPlatform
MarketData.getMarketInfoByContractsearly-returns{}whenplatformIdisundefined, and downstream callers (e.g. intransaction/decoder.tswithif (marketInfo[tx.to!])) guard against missing entries, so no errors occur and missing data is handled gracefully.
dad3a3e
into
enkryptcom:devop/package-upgrades-2-11
Summary by CodeRabbit