Skip to content

Comments

feat: add TAC mainnet#745

Merged
kvhnuke merged 3 commits intoenkryptcom:devop/package-upgrades-2-11from
suhailkakar:main
Sep 2, 2025
Merged

feat: add TAC mainnet#745
kvhnuke merged 3 commits intoenkryptcom:devop/package-upgrades-2-11from
suhailkakar:main

Conversation

@suhailkakar
Copy link
Contributor

@suhailkakar suhailkakar commented Sep 1, 2025

Summary by CodeRabbit

  • New Features
    • Added support for the TAC network.
    • Connect to TAC using a preconfigured RPC endpoint.
    • See the TAC network name, ticker, and icon across the app.
    • View activity and transactions with integrated explorer links.
    • Open transactions and addresses directly on the TAC block explorer.
    • Asset information and balances now available for TAC.

@coderabbitai
Copy link

coderabbitai bot commented Sep 1, 2025

Walkthrough

Adds TAC as a new EVM network: defines a TAC network configuration, registers it in the Ethereum networks index, and adds TAC to the NetworkNames enum.

Changes

Cohort / File(s) Summary
Network registration
packages/extension/src/providers/ethereum/networks/index.ts
Imports the new tac network module and exposes it on the networks default export object (adds tac property).
New TAC network config
packages/extension/src/providers/ethereum/networks/tac.ts
Adds TAC EvmNetwork instance with options: name: NetworkNames.TAC, name_long: "TAC", homePage: "https://tac.build", explorer templates (https://explorer.tac.build/...), chainID: "0xef", isTestNetwork: false, currency TAC, RPC https://rpc.ankr.com/tac, icon tac.webp, assetsInfoHandler, and activityHandler via wrapActivityHandler(EtherscanActivity). Exports the instantiated network as default.
Types update
packages/types/src/networks.ts
Adds TAC = "TAC" to the NetworkNames enum.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Wallet
  participant NetworksIndex as "Networks Index"
  participant TAC as "EvmNetwork: TAC"
  participant Assets as "assetsInfoHandler"
  participant Activity as "wrapActivityHandler(EtherscanActivity)"

  User->>Wallet: Choose TAC network / view account
  Wallet->>NetworksIndex: Resolve network by name (TAC)
  NetworksIndex->>TAC: Return TAC network config
  Wallet->>TAC: Request assets
  TAC->>Assets: Fetch assets metadata
  Assets-->>TAC: Return assets metadata
  TAC-->>Wallet: Provide assets

  User->>Wallet: Request activity
  Wallet->>TAC: Fetch activity
  TAC->>Activity: Query Etherscan-compatible API
  Activity-->>TAC: Return activity list
  TAC-->>Wallet: Provide activity
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • kvhnuke
  • SemajaM8

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5a61a02 and 6fad677.

📒 Files selected for processing (1)
  • packages/extension/src/providers/ethereum/networks/tac.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/extension/src/providers/ethereum/networks/tac.ts
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1b2c545 and 5a61a02.

📒 Files selected for processing (3)
  • packages/extension/src/providers/ethereum/networks/index.ts (2 hunks)
  • packages/extension/src/providers/ethereum/networks/tac.ts (1 hunks)
  • packages/types/src/networks.ts (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
packages/extension/src/providers/ethereum/networks/tac.ts (2)
packages/extension/src/providers/ethereum/types/evm-network.ts (2)
  • EvmNetworkOptions (22-53)
  • EvmNetwork (55-286)
packages/extension/src/providers/ethereum/libs/activity-handlers/index.ts (1)
  • EtherscanActivity (10-10)
🔇 Additional comments (6)
packages/types/src/networks.ts (1)

115-116: Enum entry looks good

Adding TAC to NetworkNames is consistent with the new network integration.

packages/extension/src/providers/ethereum/networks/index.ts (1)

81-82: Registry wiring is correct

Import and export of tac follow existing patterns; no issues spotted.

Also applies to: 172-173

packages/extension/src/providers/ethereum/networks/tac.ts (4)

18-18: RPC endpoint is valid

https://rpc.ankr.com/tac is an official TAC RPC on Ankr. No change needed. (ankr.com)


1-1: Icon asset present. Verified packages/extension/src/providers/ethereum/networks/icons/tac.webp exists and matches the import path.


12-13: Explorer APIs confirmed
Both https://tac.blockscout.com/api and https://explorer.tac.build/api return HTTP 200 for the module=account&action=txlist Etherscan-style request, confirming API compatibility for the activity handler.


20-23: No changes needed for missing coingeckoPlatform
MarketData.getMarketInfoByContracts early-returns {} when platformId is undefined, and downstream callers (e.g. in transaction/decoder.ts with if (marketInfo[tx.to!])) guard against missing entries, so no errors occur and missing data is handled gracefully.

@kvhnuke kvhnuke changed the base branch from main to devop/package-upgrades-2-11 September 2, 2025 20:34
@kvhnuke kvhnuke merged commit dad3a3e into enkryptcom:devop/package-upgrades-2-11 Sep 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants