Skip to content

Comments

Fix okx tx issue#730

Merged
kvhnuke merged 14 commits intoenkryptcom:feat/okx-sol-swapfrom
Julian-dev28:fix-okx-tx-issue
Jul 17, 2025
Merged

Fix okx tx issue#730
kvhnuke merged 14 commits intoenkryptcom:feat/okx-sol-swapfrom
Julian-dev28:fix-okx-tx-issue

Conversation

@Julian-dev28
Copy link
Contributor

This pull request updates the OKX provider integration in the packages/swap/src/providers/okx/index.ts file to enhance compatibility with Solana transactions, improve API request handling, and add better debugging and error handling. The most important changes include switching to legacy Solana transactions, updating API endpoints, refining parameter handling for quotes and swaps, and introducing a new method to process OKX transaction data into valid Solana transactions.

Enhancements to Solana transaction handling:

  • Changed the transaction type to legacy to accommodate OKX's custom instruction data, as opposed to standard Solana transactions.
  • Added a new method, createSolanaTransactionFromOKXData, to convert OKX transaction data into valid Solana transactions, ensuring proper deserialization, fee payer updates, and blockhash assignment.

API endpoint updates:

  • Updated the OKX API base URL and endpoint paths for tokens, quotes, and swaps to align with the new API structure.

Improvements to parameter handling:

  • Adjusted quote parameters to exclude unnecessary fields and conditionally include feePercent only when valid (greater than 0 and less than or equal to 10).
  • Refined swap parameters to ensure proper handling of native and wrapped SOL addresses, added required fields like autoSlippage, and conditionally included fee-related fields.

Debugging and logging enhancements:

  • Added detailed debug logs for quote and swap parameters, as well as for the process of converting OKX transaction data to Solana transactions, to aid in troubleshooting and validation. [1] [2]

@coderabbitai
Copy link

coderabbitai bot commented Jul 10, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • main
  • develop
  • devop/vite-migrate

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Julian-dev28 Julian-dev28 marked this pull request as draft July 10, 2025 09:14
@Julian-dev28 Julian-dev28 marked this pull request as ready for review July 16, 2025 05:02
@kvhnuke kvhnuke merged commit 6c073a3 into enkryptcom:feat/okx-sol-swap Jul 17, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants