Enable Changelly swaps on Rootstock

[ahsan-javaiid]

Description

This PR adds minor fixes to enable Changelly swaps on Rootstock. Currently fix rate is enabled for rif token but for rbtc the fix rate is not enabled. So suggesting if it's acceptable to bypass rbtc fix rate and include it for changelly swaps.

Demo

Summary by CodeRabbit

• Bug Fixes
  • Improved compatibility with Rootstock checksum addresses when retrieving transaction counts by converting addresses to lowercase.
  • Expanded token support in swaps to include tokens using the "RBTC" protocol, allowing them to be used as native currency for gas fees and swaps.

[coderabbitai]

Walkthrough

The updates adjust address handling in Ethereum transaction nonce retrieval by converting addresses to lowercase, ensuring compatibility with web3. Additionally, the Changelly provider's token initialization now includes tokens with the "RBTC" protocol, not just those with fixRateEnabled, expanding eligible tokens for swaps and gas fees.

Changes

File(s)	Change Summary
packages/extension/src/providers/ethereum/libs/transaction/index.ts	Converts sender address to lowercase before retrieving transaction count to ensure web3 compatibility.
packages/swap/src/providers/changelly/index.ts	Updates token filtering to include tokens where protocol is "RBTC" or fixRateEnabled is true.

Suggested reviewers

• kvhnuke

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/swap/src/providers/changelly/index.ts (1)

134-139: Case-insensitive protocol check & optional chaining

cur.protocol may be undefined for some entries.
Using optional chaining and a case-insensitive comparison avoids a possible
runtime error and future-proofs the filter.

-        (cur.fixRateEnabled || cur.protocol === "RBTC") && // Allow RBTC as native currency for gas fees and swaps
+        (cur.fixRateEnabled || cur.protocol?.toUpperCase() === "RBTC") && // Allow RBTC as native currency for gas fees and swaps

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 13df0aa and f1f4567.

📒 Files selected for processing (2)

• packages/extension/src/providers/ethereum/libs/transaction/index.ts (1 hunks)
• packages/swap/src/providers/changelly/index.ts (1 hunks)

🔇 Additional comments (1)

packages/extension/src/providers/ethereum/libs/transaction/index.ts (1)

108-108: Guard against missing from before calling .toLowerCase()

this.tx.from is now dereferenced for toLowerCase() unconditionally.
If, for any reason, the caller forgets to populate from, this will throw a TypeError long before the intended validation path. A quick nil-check (or an early explicit error) makes the failure mode clearer.

-const nonce = await this.web3.getTransactionCount(this.tx.from.toLowerCase(), 'pending');
+if (!this.tx.from)
+  throw new Error("Transaction.from is required to compute nonce");
+const nonce = await this.web3.getTransactionCount(
+  this.tx.from.toLowerCase(),
+  "pending",
+);