This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Fix: further simplify geopicker widget selector #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyelidlessness
force-pushed
the
fix/geo-selector-not-complexity
branch
from
16b25b0 to
a6b7add
Compare
lognaturel
approved these changes
Feb 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes enketo/enketo#41. This is much narrower than the solution discussed there (detecting unused widgets on load so they don't continually query). It's probably worth doing as a separate change, but feels like overkill for this fix and probably best to evaluate its risk separately.