This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Fix: rank widget on touch devices #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes enketo/enketo-express#511
Verified on Moto G5 Chrome 109.0.5414.117
Not strictly necessary, but I also restricted touch dragging to the visible handle area (with some padding). I did this because testing on my own phone (iPhone, which turned out to reproduce the bug as well), I found it quite difficult to scroll anywhere near a rank question, and there's already a visible appearance of a handle on the side. Along with this change, I removed the "hover" effect on the full width rank options, because it no longer corresponds to the actionable area and could be confusing.
Happy to discuss those changes or make them separate, but I do think it would be a worse UX.