This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Fix: integer and decimal widgets remain visible when form language changes #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes and unifies changed language behavior, and re-formatting values when decimal characters change. Moves visibility fix to styles, as it's a core stylesheet and should be safe to change there. It's not yet clear what a safe but more specific selector would be, but it is clear that transformer doesn't set translation `lang` atttributes directly on question elements
lognaturel
approved these changes
Dec 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes enketo/enketo-express#507. I added a comment explaining the nature of the fix.
The seemingly unrelated change in
form.jsfixes a bug I discovered when I explored changingloadFormto handle appending the form element, where explicitly passingnullas options passes theobjectcheck, becausenullis... of course anobject. It seemed a small enough tangential fix that it wasn't worth a whole separate PR.