This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] Create release PR - [x] Check [Dependabot](https://github.com/enketo/enketo-transformer/security/dependabot) for alerts - [x] Run `npm update` - [x] Check if `node-forge` has been updated and if so, verify encrypted submissions end-to-end - [x] Run `npm audit` - Run `npm audit fix --production` to apply most important fixes - [x] Run `npm ci` - [x] Run `npm test` - [x] Run `npm run build-docs` - [x] Update `CHANGELOG.md` - [x] Update version in `package.json` - N/A: Bump to major version if consumers have to make changes. - [ ] Merge PR with all changes @lognaturel - [ ] Create GitHub release @lognaturel - [ ] Tag and publish the release @lognaturel - GitHub Action will publish it to npm
eyelidlessness
added a commit
to eyelidlessness/enketo-express
that referenced
this pull request
Feb 5, 2022
**Note:** this will need to be updated again, pending release of [enketo-core 6.0.4](enketo/enketo-core#863) - [x] Create release PR - [ ] Check [Dependabot](https://github.com/enketo/enketo-express/security/dependabot) for alerts - [x] Run `npm update` - [x] Check if `node-forge` has been updated and if so, verify encrypted submissions end-to-end - [x] Run `npm audit` - [x] Run `npm audit fix --production` to apply most important fixes - **Note** there is an outstanding dependency vulnerability for `jstransformer-markdown-it`, which is only used to render `CHANGELOG.md` as HTML, which does not process arbitrary user input - [x] Run `npm ci` - [x] Run `npm test` - [x] Run `npm run build-docs` - [x] Update `CHANGELOG.md` - [x] Update version in `package.json` - N/A: Bump to major version if consumers have to make changes. - [ ] Merge PR with all changes @lognaturel - [ ] Create GitHub release @lognaturel - [ ] Tag and publish the release @lognaturel - GitHub Action will publish it to npm
14 tasks
lognaturel
approved these changes
Feb 5, 2022
eyelidlessness
added a commit
to eyelidlessness/enketo-express
that referenced
this pull request
Feb 7, 2022
**Note:** this will need to be updated again, pending release of [enketo-core 6.0.4](enketo/enketo-core#863) - [x] Create release PR - [ ] Check [Dependabot](https://github.com/enketo/enketo-express/security/dependabot) for alerts - [x] Run `npm update` - [x] Check if `node-forge` has been updated and if so, verify encrypted submissions end-to-end - [x] Run `npm audit` - [x] Run `npm audit fix --production` to apply most important fixes - **Note** there is an outstanding dependency vulnerability for `jstransformer-markdown-it`, which is only used to render `CHANGELOG.md` as HTML, which does not process arbitrary user input - [x] Run `npm ci` - [x] Run `npm test` - [x] Run `npm run build-docs` - [x] Update `CHANGELOG.md` - [x] Update version in `package.json` - N/A: Bump to major version if consumers have to make changes. - [ ] Merge PR with all changes @lognaturel - [ ] Create GitHub release @lognaturel - [ ] Tag and publish the release @lognaturel - GitHub Action will publish it to npm
eyelidlessness
added a commit
to eyelidlessness/enketo-express
that referenced
this pull request
Feb 9, 2022
**Note:** this will need to be updated again, pending release of [enketo-core 6.0.4](enketo/enketo-core#863) - [x] Create release PR - [ ] Check [Dependabot](https://github.com/enketo/enketo-express/security/dependabot) for alerts - [x] Run `npm update` - [x] Check if `node-forge` has been updated and if so, verify encrypted submissions end-to-end - [x] Run `npm audit` - [x] Run `npm audit fix --production` to apply most important fixes - **Note** there is an outstanding dependency vulnerability for `jstransformer-markdown-it`, which is only used to render `CHANGELOG.md` as HTML, which does not process arbitrary user input - [x] Run `npm ci` - [x] Run `npm test` - [x] Run `npm run build-docs` - [x] Update `CHANGELOG.md` - [x] Update version in `package.json` - N/A: Bump to major version if consumers have to make changes. - [ ] Merge PR with all changes @lognaturel - [ ] Create GitHub release @lognaturel - [ ] Tag and publish the release @lognaturel - GitHub Action will publish it to npm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I think we can safely remove
node-forge
from enketo-core, which doesn't directly use it anywhere I can find. Unless there's some dynamic usage I'm not aware of which wouldn't be provided by dependent projects, I'd prefer to remove it both as a dependency and as a step in the release process.npm update
node-forge
has been updated and if so, verify encrypted submissions end-to-endnpm audit
npm audit fix --production
to apply most important fixesnpm ci
npm test
npm run build-docs
CHANGELOG.md
package.json