Repository navigation
fix(chat): stop loading missing thread messages forever - #76
Merged
Merged
Conversation
github-actions
Bot
added
the
vouch:trusted
# Conflicts: # packages/client-runtime/src/state/threads.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stale thread shell can outlive its detail projection. When that happens, clients repeatedly request a missing snapshot every 250 ms and leave the chat permanently showing “Loading messages…”.
Mark server-confirmed missing thread details as deleted, attach a structured
not_foundreason to the wire error, and resume from the retained cursor so the client does not restart the missing snapshot request. The client keeps message-based compatibility with older servers.Verification:
vp test run packages/client-runtime/src/state/threads-sync.test.tsvp test run apps/server/src/server.test.ts -t "identifies a missing thread snapshot"Created with GPT-5.6 Sol via the Codex harness in T3 Code.