ToLowerContainsComparison with GUID field

[wahmedswl]

Hi!

ToLowerContainsComparison filter doesn't apply anything if it include GUID field.

public class ExampleFilter : PaginationFilterBase
{
    [ToLowerContainsComparison]
    [CompareTo(
        "BotStatus",
        "SmeStatus",
        "AssignedTo",
        CombineWith = CombineType.Or
    )]
    [StringFilterOptions(StringFilterOption.Contains)]
    public string? Search { get; set; }

    [ArraySearchFilter]
    public List<string>? BotStatus { get; set; }

    [ArraySearchFilter]
    public List<string>? SmeStatus { get; set; }

    [ArraySearchFilter]
    public List<Guid>? AssignedTo { get; set; }
}

Thanks

[enisn]

Types are mismatching. AutoFilterer doesn't have any converter to Guid. If you filter isn't Guid, it cannot compare it to Guid.

Comparison directly triesto call AssignedTo.Contains(filter.Search) expression and it is not applicaple filter since list has Guids and search is string.

AutoFilterer/src/AutoFilterer/Attributes/ToLowerContainsComparisonAttribute.cs

Line 20 in 39c7454

var comparison = Expression.Equal(

There are 2 options here:

• We can throw exception in this kind of cases
  or
• We can just ignore only sinlge field when type mismatches and write a log about it.

As a better solution, there might be a type conversation logic, but it brings a lot more complexity

[wahmedswl]

Thanks for quickly looking into the issue. I guess throw exception, logging it will not be much good to let user know because not everyone look at them 😅

[enisn]

I'll still think about this scenario and consider making an enhancement, maybe supporting type-conversation for primitive types

[wahmedswl]

Yeah, it's good to have. Meanwhile, if someone encounters this they can look at this ticket