Draft
Conversation
Explores the addition of a client to manage communication with an instance of an ldk-server. We realize early the disparity between the local node information APIs exposed by LDK, relative to LND and CLN, and need to add feature support on ldk-node/server to permit the retrieval of the running node's network and features. These are necessary for sim-ln's validation logic as: - network ensures all nodes run on the same network, and also do not run on the mainnet - features ensure that keysend support is enabled
a6fcf00 to
e9abc14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Exploratory PR to support LDK server, i.e. LDK node daemon, as one of
sim-ln's node targets.As efforts progress and required LDK-dependent feature set identified, corresponding PRs will
be opened on
ldk-node/serverto enable integration.Required LDK feature set*
To integrate
sim-ln:ldk-node, we need to enable, or make accessible, the following:networkavailable in request to get node informationNodeFeaturesavailable in request to get node information*Will be modified as new features are discovered