Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add password reset request #13

Merged
merged 2 commits into from
Aug 3, 2015
Merged

add password reset request #13

merged 2 commits into from
Aug 3, 2015

Conversation

adamreese
Copy link
Contributor

No description provided.

lanej
lanej reviewed Jul 23, 2015
View reviewed changes
lib/ey-core/requests/password_resets.rb
end # Real

class Mock
def password_resets(_params)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd call this reset_password, password_resets sounds like an index request

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

names are hard

michelleN pushed a commit that referenced this pull request Aug 3, 2015
Merge pull request #13 from engineyard/password-reset
f55970a 
add password reset request
@michelleN michelleN merged commit f55970a into master Aug 3, 2015
@michelleN michelleN deleted the password-reset branch August 3, 2015 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamreese @lanej @michelleN