Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server cli improvements #103

Merged
merged 3 commits into from
Apr 4, 2018
Merged

Server cli improvements #103

merged 3 commits into from
Apr 4, 2018

Conversation

binarypaladin
Copy link
Contributor

After transitioning our project to Ruby 2.4 we started using ey-core instead of ey due to some issues with ey. We have multiple accounts with the same environment names (e.g. "production" and "staging") and existing implementation:

  1. Was broken in terms of filtering by account.
  2. Had an incorrect short flag for environments.
  3. Made it impossible to get the servers for an environment that had the same name as an environment of the default account.

Additionally, the table output has been altered to include the public hostname. In our own use cases for ey this was probably the most regularly used information.

The previous iteration returned an error when specifying an account. Furthermore, when a user has access to multiple accounts with multiple environments of the same name, the environments toggle would return only return the environment for the main account—and since the account couldn’t be set, this was problematic. Also, the environments short option has been fixed (“-e” has been changed to “e”).
For the purpose of ssh and other operations when using the CLI, the public hostname is a pretty common need.
@ddiachkov ddiachkov merged commit cae9234 into engineyard:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants