Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): release workflow, rye version and poetry version differs #390

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

engeir
Copy link
Owner

@engeir engeir commented Feb 27, 2024

No description provided.

@engeir engeir added the ci Continuous Integration label Feb 27, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Bug fix

PR Summary: This pull request addresses an issue with the release workflow in the GitHub actions configuration, specifically targeting the command used to retrieve the version from the 'rye' environment. The change simplifies the command by directly using the output of 'rye version' without additional processing through 'awk'.

Decision: Comment

📝 Type: 'Bug fix' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that the output of 'rye version' is in a format that can be directly used without further processing. If the output format includes additional information that is not needed, consider if any adjustments are necessary either in the 'rye version' command output or in how the output is consumed.
  • Verify that this change aligns with the overall workflow and does not introduce discrepancies between the versioning used by 'rye' and any other tools or processes involved in the release workflow, such as 'poetry'.
  • Given the nature of the change, it would be beneficial to include a brief explanation in the PR description about why the previous 'awk' processing is no longer needed. This will help reviewers understand the context and rationale behind the change.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@engeir engeir merged commit 471d5cf into main Feb 27, 2024
33 checks passed
@engeir engeir deleted the fix-release-workflow branch February 27, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant