Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ncdump): don't print info in section heading #270

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Conversation

engeir
Copy link
Owner

@engeir engeir commented Nov 4, 2022

Fixes #263.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 4, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.06%.

Quality metrics Before After Change
Complexity 32.00 😞 32.00 😞 0.00
Method Length 242.00 ⛔ 239.50 ⛔ -2.50 👍
Working memory 0.00 ⭐ 0.00 ⭐ 0.00
Quality 13.85% 13.91% 0.06% 👍
Other metrics Before After Change
Lines 161 161 0
Changed files Quality Before Quality After Quality Change
src/ncdump_rich/ncdump.py 13.85% ⛔ 13.91% ⛔ 0.06% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/ncdump_rich/ncdump.py ncdump 32 😞 458 ⛔ 13.91% ⛔ Refactor to reduce nesting. Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@engeir engeir added the bug Something isn't working label Nov 4, 2022
@engeir engeir merged commit 2a8f012 into main Nov 4, 2022
@engeir engeir deleted the remove-duplicate-info branch November 4, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File Format duplicated in group name
1 participant