Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend to python 3 7 #267

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Extend to python 3 7 #267

merged 2 commits into from
Nov 4, 2022

Conversation

engeir
Copy link
Owner

@engeir engeir commented Nov 4, 2022

Downgrades numpy, among other libraries, to be able to run with python3.7.

Removes a few calls to numpy arrays from tests. Numpy is still a
dependency, but not explicitly used in the code.
@engeir engeir added dependencies Pull requests that update a dependency file build Build System and Dependencies ci Continuous Integration labels Nov 4, 2022
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 4, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.82%.

Quality metrics Before After Change
Complexity 3.05 ⭐ 3.14 ⭐ 0.09 👎
Method Length 83.25 🙂 85.60 🙂 2.35 👎
Working memory 8.39 🙂 8.55 🙂 0.16 👎
Quality 65.56% 🙂 64.74% 🙂 -0.82% 👎
Other metrics Before After Change
Lines 291 291 0
Changed files Quality Before Quality After Quality Change
noxfile.py 77.54% ⭐ 76.72% ⭐ -0.82% 👎
tests/test_main.py 46.11% 😞 46.14% 😞 0.03% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
tests/test_main.py test_main_succeeds 1 ⭐ 475 ⛔ 13 😞 44.16% 😞 Try splitting into smaller methods. Extract out complex expressions
noxfile.py activate_virtualenv_in_precommit_hooks 14 🙂 161 😞 9 🙂 50.62% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@engeir engeir merged commit 352edd7 into main Nov 4, 2022
@engeir engeir deleted the extend-to-python-3_7 branch November 4, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build System and Dependencies ci Continuous Integration dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant