Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nc_savefile): open in lock=False mode #16

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

engeir
Copy link
Owner

@engeir engeir commented Jul 25, 2023

Issue also described and tracked in
pydata/xarray#3961.

@engeir engeir added bug Something isn't working enhancement New feature or request labels Jul 25, 2023
@engeir engeir merged commit 6f335ce into simple-tests Jul 25, 2023
@engeir engeir deleted the fix-save-hang branch July 25, 2023 08:37
engeir added a commit that referenced this pull request Jul 25, 2023
* test(gen_agg): create dummy files and execute stuff

* test(gen_agg): stuff is working

Next: add feat to gen_agg so that files can be appended.

* test(gen_agg): split into many generated files

The time span attribute is moved to the global attribute of the dataset,
which makes it so it is transferred over to the history field of the new
concatenated file when using `ncrcat`.

* perf(close): close all opened datasets in gen_agg (#15)

* fix(nc_savefile): open in lock=False mode (#16)

Issue also described and tracked in
pydata/xarray#3961.

* test(gen_agg): test against different netCDF formats

All file formats supported by xarray now works in the tests. Good stuff.

* ci: set up workflows for labeler and release draft (#19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant