Skip to content

Fix deployment pipeline issues #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
banstack merged 1 commit into from
Jun 30, 2022
Merged

Fix deployment pipeline issues #593

banstack merged 1 commit into from
Jun 30, 2022

Conversation

@kdvalin
Copy link
Contributor

@kdvalin kdvalin commented Jun 30, 2022

Updated instances of SSH fetching in package-lock.json to use HTTPS instead.

Recommended Action Items

  • Figure out why SSH fetching was occurring (look at dependabot first)
  • Update git to only use HTTPS fetching in the pipeline (maybe something like this)
  • Add a container building step in PRs

@banstack banstack self-requested a review June 30, 2022 20:07
banstack
banstack approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@banstack banstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm will focus on the fixes

@banstack banstack merged commit 12e82bf into engaging-computing:dev Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@banstack banstack banstack approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kdvalin @banstack