Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 95% CI error bars to CE and CW examples (Sourcery refactored) #19

Closed
wants to merge 1 commit into from

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Jan 19, 2023

Pull Request #14 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the error_bars branch, then run:

git fetch origin sourcery/error_bars
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from endolith January 19, 2023 17:45
@sourcery-ai
Copy link
Author

sourcery-ai bot commented Jan 19, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.08%.

Quality metrics Before After Change
Complexity 25.80 😞 25.79 😞 -0.01 👍
Method Length 381.40 ⛔ 380.60 ⛔ -0.80 👍
Working memory 20.84 ⛔ 20.83 ⛔ -0.01 👍
Quality 24.58% 24.66% 0.08% 👍
Other metrics Before After Change
Lines 395 398 3
Changed files Quality Before Quality After Quality Change
examples/merrill_1984_fig_2c_2d.py 7.09% ⛔ 7.09% ⛔ 0.00%
examples/merrill_1984_table_1_fig_1.py 13.13% ⛔ 13.13% ⛔ 0.00%
examples/wikipedia_condorcet_paradox_likelihood.py 69.29% 🙂 69.29% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c93a525) 97.40% compared to head (9c93897) 97.40%.

Additional details and impacted files
@@             Coverage Diff             @@
##           error_bars      #19   +/-   ##
===========================================
  Coverage       97.40%   97.40%           
===========================================
  Files              18       18           
  Lines             463      463           
===========================================
  Hits              451      451           
  Misses             12       12           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sourcery-ai sourcery-ai bot force-pushed the sourcery/error_bars branch from a3e0575 to 9c93897 Compare March 13, 2023 03:15
@@ -41,6 +41,7 @@
running as many simulations, however the Coombs results are consistently
high.
"""

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 96-96 refactored with the following changes:

@@ -24,6 +24,7 @@
| SU max | 100.0 | 84.1 | 79.6 | 78.4 | 77.3 | 77.5 |
| CW | 100.0 | 91.7 | 83.1 | 75.6 | 64.3 | 52.9 |
"""

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 54-133 refactored with the following changes:

This removes the following comments ( why? ):

# Likelihood of Condorcet Winner (normalized by n elections)

for iteration in range(batch_size):
for _ in range(batch_size):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function simulate_batch refactored with the following changes:

@endolith endolith closed this Mar 13, 2023
@endolith endolith deleted the sourcery/error_bars branch March 13, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant