fix(init): workaround node promise destroyed bug #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
approved these changes
Apr 20, 2022
naugtur
pushed a commit
that referenced
this pull request
May 16, 2022
naugtur
pushed a commit
that referenced
this pull request
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1115 landed in agoric-sdk, people stated experiencing errors like
TypeError#1: Cannot assign to read only property 'Symbol(destroyed)' of object '[object Promise]'The patch was overzealous and set the property as non-configurable and non-writable. This isn't a problem for the
async_idandtrigger_async_idsymbols since node tests for their presence before assigning, however it seems node unconditionally set the destroyed symbol, and being an object, the description doesn't match (different value), and the later assignment throws.I am not quite sure under which circumstances this situation arises, or I'd add a test for it.