Skip to content

Should we stop suppressing the override mistake for Function.prototype.apply? #474

Closed
@erights

Description

@erights

At https://github.com/Agoric/SES-shim/blob/9a7a0975036d8d938263ba265f747876d7d91599/packages/ses/src/enablements.js#L67 we say that we added Function.prototype.apply to the enablements whitelist because of tape.

At #473 (comment) @ljharb says that tape does not do an overriding assign to apply. If tape is no longer a problem, or if we were mistaken about whether it was a problem in the first place, and if we do not encounter any other such problems, we should remove Function.prototype.apply from the enablements whitelist.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions