StoryWeaver: Use different animation for attack

[manuq]

Use the animation named "Attack 02" in the Aseprite source file for the SpriteFrames animation "Attack 01".

Ideally we would change the AnimationPlayer in the Player scene to just use Attack 02. But we can't do that without also adding back "Attack 02" to the template for the player. That "Attack 02" animation was removed from the player template upon request, to avoid confusion in learners, as the animation wasn't used.

So, rename animation "Attack_01" to "Attack_unused" in StoryWeaver SpriteFrames in all color variations. And rename "Attack_02" to "Attack_01".

This is confusing, but may be the only thing we can do at this point.

Fixes #509

[manuq]

@wjt ready for review. I have removed the requirement of the unused animation, because the template was warning about it.

[wjt]

https://endlessm.github.io/threadbare/branches/endlessm/storyweaver-attack-animation/#quests/lore_quests/quest_001/2_ink_combat/ink_combat_round_1

[wjt]

LGTM.

You could consider renaming the animations in the Aseprite source file to match?

[manuq]

LGTM.

You could consider renaming the animations in the Aseprite source file to match?

Honestly I don't want to go with the inconsistency that this leaves. The Aseprite source of the template has Attack 01 matching the Aseprite source of the StoryWeaver Attack 01. Same for Attack 02. So if I change Storyweaver.aseprite and not player_template.aseprite it will become inconsistent. Should we leave this out for now, until we can modify the template again? Also, when will be the next window to change the template? After Stella is merged? After the first program ends?

[wjt]

Ahh, now I understand. I had misunderstood that the template only has one animation. But there are two in its Aseprite source file: Attack 01 is a swipe, Attack 02 is a shield. Similar to StoryWeaver.aseprite.

Then we have storyweaver_blue.tres SpriteFrames (resp. other colours) with matching attack_01 and attack_02 animations. The template_player.tres SpriteFrames only defines attack_01 – but both attack_01 and attack_02 are exported as PNGs alongside it.

So for consistency we have the following options:

1. Swap the template's attack animations (in the spriteframes, exported PNGs, and Aseprite file) along with StoryWeaver's;
2. Define attack_02 in the template SpriteFrames; remove attack_01; and make the Player scene use attack_02;
3. Keep using the existing swipe-of-needle animation.

Options 1 and 2 will (very slightly...) invalidate the course materials that are being prepared/have been prepared. Option 3 means leaving #509 open.

I think that unless 1 or 2 are unexpectedly acceptable (and the relevant people have other things to think about this week) we should take option 3...

Also, when will be the next window to change the template? After Stella is merged? After the first program ends?

I think it's probably too late for the first program now but we may need to consider having programs work from a release branch (doesn't currently exist), or the latest tag (we don't have one), rather than from main in future so that we don't have this tight coupling.