Importcontent manifest file v015 #25
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the same list of nodes selected for export, we can generate a set of node IDs which work with importcontent.
This case indicates that all of the content from the channel is included. It is distinct from include_node_ids being an empty list, which suggests that none of the content is included.
When node_ids and exclude_node_ids are empty lists, we can understand this to mean that no nodes are being selected. This is distinct from when they are None, which means the default behaviour of selecting all nodes. This is useful to provide a sane fallback when a manifest file has no information about a channel.
This reverts commit 5980d9b.
When node_ids is set to an empty list, importcontent will understand that to mean "no nodes", which is different from when node_ids is unset.
danigm
force-pushed
the
importcontent-manifest-file-v015
branch
from
4aa0b15 to
5285c16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the learningequality#9467 PR to v0.15