Add is_input_actioned.tres #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanmccall
force-pushed
the
input-block-extension
branch
3 times, most recently
from
10a1fa4 to
5ecd03b
Compare
starnight
requested changes
Sep 20, 2024
Contributor
starnight
left a comment
starnight
left a comment
There was a problem hiding this comment.
Thanks for helping move the input key action block into a single tres. I place some review comments. :)
This replaces the block definition generated in BlocksCatalog. Instead, the static block definition includes an extension script which generates a list of action name options.
dylanmccall
force-pushed
the
input-block-extension
branch
from
5ecd03b to
77d67d5
Compare
Contributor
Author
|
Thanks for the review @starnight! I fixed those details in the newest commit. |
starnight
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a block extension script to generate an options list instead of
BlocksCatalog._get_inputmap_actions.