Generate value blocks for AnimationPlayer animations #191
Conversation
It is possible for the list of animations to change based on changes done in another panel. This causes the list of animation value blocks in the Block Code panel to become stale. Ideally we should watch the mixer_updated signal in an AnimationPlayer node, but at the moment this would be difficult to implement. Watching for the panel being shown will work around the issue for a reasonable number of situations. https://phabricator.endlessm.com/T35564
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
This looks great, only a nit comment. I think it's fine to refresh the animations every time the panel is shown, as the last commit does. Maybe later we can add a refresh button in the title bar.
I wonder if we should join forces and land #147 first.
addons/block_code/ui/main_panel.gd
Outdated
|
|
||
| var block_script: BlockScriptSerialization = _current_block_code_node.block_script | ||
| _picker.block_script_selected(block_script) | ||
| _picker.block_script_selected(block_script, _current_block_code_node.get_parent() if _current_block_code_node else null) |
There was a problem hiding this comment.
The line above is assuming that _current_block_code_node is not null (it is referencing block_script in it.
In any case, this would be a bit more readable without a ternary operator.
| if _current_block_code_node != null: | ||
| _try_migration() | ||
| _picker.block_script_selected(block_script) | ||
| _picker.block_script_selected(block_script, _current_block_code_node.get_parent() if _current_block_code_node else null) |
There was a problem hiding this comment.
Nit: this would be a bit more readable without a ternary operator. Or at least moving the conditional to a variable:
var parent_node: Node = _current_block_code_node.get_parent() if _current_block_code_node else null
_picker.block_script_selected(block_script, parent_node)
| static func get_blocks_for_object(object: Object) -> Array[Block]: | ||
| var blocks: Array[Block] = [] | ||
| return blocks |
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
Sorry for the double review. Now I gave it a try and it's not working. The generated script is missing the quotes around the aniimation name:
Grabación de pantalla desde 2024-08-12 15-22-52.webm
This makes me wonder if the animation values should be options in a dropdown of the Play block. Otherwise these are string blocks that can be used anywhere else, but are only relevant for playing the animation.
Yeah, I'll give that a try :) In that case it'll definitely need to be on top of #147, and might need some new pieces? But I'll see where I can get it! |
|
@dylanmccall I believe this all got reimplemented in #206, correct? Can we close this? |
|
Yes! Thanks for remembering. |
https://phabricator.endlessm.com/T35564