Skip to content

Conversation

@danyalg
Copy link

@danyalg danyalg commented Mar 18, 2025

This pull request enhances the profile_data dictionary by concatenating multiple picture URLs from the raw_profile_data source. Specifically, it initializes profile_data["picture_url"] as an empty string and appends the following URLs:

Changes Made
Initialized profile_data["picture_url"] as an empty string.
Appended raw_profile_data["displayPictureUrl"] to profile_data["picture_url"].
Appended raw_profile_data["img_100_100"] to profile_data["picture_url"], separated by a space.
Expose in final result

@endernoke endernoke self-requested a review March 19, 2025 03:39
@endernoke endernoke added the enhancement New feature or request label Mar 19, 2025
Copy link
Owner

@endernoke endernoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this feature!

I've noticed that accessing the profile picture URL seems to require LinkedIn authentication, so the frontend and end users can't use the URL directly.

One possible solution would be the backend fetch the image using an authenticated request and then serve it to the frontend.

Also, instead of treating the pic as a profile section, I think it's more user-friendly to display it directly next to the ingest title.

Thanks again, lmk what you think about these modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants