Skip to content

Fixes #74: Invalid generated output file name: index.cpptml.cpp. #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
end2endzone merged 1 commit into from
May 6, 2025
Merged

Fixes #74: Invalid generated output file name: index.cpptml.cpp. #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Changes for 3.1.0:
* Fixed issue #63: Context class redesign. Move arguments handling into a Context class.
* Fixed issue #64: Remove build artifacts of samples from installation packages.
* Fixed issue #72: Move the code FileManager class generation code into its own IGenerator implementation.
* Fixed issue #74: Invalid generated output file name: index.cpptml.cpp.


Changes for 3.0.1:
Expand Down
74 changes: 0 additions & 74 deletions samples/demo_website/www/index.html.old
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions src/bin2cpp/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,9 +564,8 @@ APP_ERROR_CODES processInputFile(const Context & c, bin2cpp::IGenerator * genera
return APP_ERROR_INPUTFILENOTFOUND;

//prepare output files path
std::string cppFilename = c.headerFilename;
ra::strings::Replace(cppFilename, ".hpp", ".cpp");
ra::strings::Replace(cppFilename, ".h", ".cpp");
std::string headerExtention = ra::filesystem::GetFileExtention(c.headerFilename);
std::string cppFilename = c.headerFilename.substr(0, c.headerFilename.size() - headerExtention.size()) + "cpp"; // strip out header file's extension and add 'cpp'.

//create a copy of the context.
//we may have already generated files from a previous call to processInputFile().
Expand Down