Skip to content

Fix .cpppp when passing .hpp header name#46

Merged
end2endzone merged 1 commit intoend2endzone:masterfrom
MatthewScholefield:fix-cpppp
Jun 4, 2021
Merged

Fix .cpppp when passing .hpp header name#46
end2endzone merged 1 commit intoend2endzone:masterfrom
MatthewScholefield:fix-cpppp

Conversation

@MatthewScholefield
Copy link
Contributor

This fixes #44.

@end2endzone
Copy link
Owner

I have reviewed changes of PR #46 and I fully agree with the correction.

However, github was unable to run the automated tests on GitHub Actions. It fails at a step where an svn badge is uploaded to one of my gist. This is certainly related to a security issue. It is working fine when my own commits trigger builds but I guess that when someone else triggers a build, it fails for an unknown reason.

I would like to take this opportunity to look at this and prevent future failures in other PR. Please allow me some time to look at it. I need to find out why the token used to upload to my gist does not work in other users PR. If you have any hint about this, I am open to suggestions.

@MatthewScholefield
Copy link
Contributor Author

I believe the problem is just that GitHub Actions doesn't use your secrets when running tests on my fork because that would allow anyone to change the test code to print the secrets. So I would suggest seeing if you could make any necessary secrets optional.

@end2endzone
Copy link
Owner

You are right. From the project's Actions secrets page: "Secrets are not passed to workflows that are triggered by a pull request from a fork. Learn more.".

I would prefer to only disable badge uploads step when running PR checks and keep building and testing proposed PR. I am currently looking for an if statements that would skip theses step when the workflow is run from a PR.

@end2endzone
Copy link
Owner

I documented the fix in #48 and committed the changes in my repository in commit 1e37ab1. Note that I have not tried the changes on an actual PR but I think it should be working according to this.

The checks in this push request seems to be running from a temporary commit 2d37df2 , 2d37df224733e4c3b4142037a9251b56425937bb:refs/remotes/pull/46/merge, according to command git log -1 --format='%H' in the logs. After I have committed 1e37ab1 to my master branch, I though that I would be able to re-run the checks again on master (including the latest commits) and get a "pass" result. But it does not seems to work that way. I will try options mentioned here. If it does not work, I will just stop trying and just accept the pull request and hope that next PR I get will be easier to manage.

@end2endzone end2endzone merged commit f01fd69 into end2endzone:master Jun 4, 2021
@end2endzone
Copy link
Owner

woot!

@MatthewScholefield MatthewScholefield deleted the fix-cpppp branch June 4, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using .hpp for header filename causes .cpppp for source file

2 participants