Fix .cpppp when passing .hpp header name#46
Fix .cpppp when passing .hpp header name#46end2endzone merged 1 commit intoend2endzone:masterfrom MatthewScholefield:fix-cpppp
Conversation
|
I have reviewed changes of PR #46 and I fully agree with the correction. However, github was unable to run the automated tests on GitHub Actions. It fails at a step where an svn badge is uploaded to one of my gist. This is certainly related to a security issue. It is working fine when my own commits trigger builds but I guess that when someone else triggers a build, it fails for an unknown reason. I would like to take this opportunity to look at this and prevent future failures in other PR. Please allow me some time to look at it. I need to find out why the token used to upload to my gist does not work in other users PR. If you have any hint about this, I am open to suggestions. |
|
I believe the problem is just that GitHub Actions doesn't use your secrets when running tests on my fork because that would allow anyone to change the test code to print the secrets. So I would suggest seeing if you could make any necessary secrets optional. |
|
You are right. From the project's Actions secrets page: "Secrets are not passed to workflows that are triggered by a pull request from a fork. Learn more.". I would prefer to only disable badge uploads step when running PR checks and keep building and testing proposed PR. I am currently looking for an |
|
I documented the fix in #48 and committed the changes in my repository in commit 1e37ab1. Note that I have not tried the changes on an actual PR but I think it should be working according to this. The checks in this push request seems to be running from a temporary commit 2d37df2 , |
|
woot! |
This fixes #44.