Skip to content

Fix CMake configuration without tests#45

Merged
end2endzone merged 1 commit intoend2endzone:masterfrom
MatthewScholefield:fix-cmake
Jun 6, 2021
Merged

Fix CMake configuration without tests#45
end2endzone merged 1 commit intoend2endzone:masterfrom
MatthewScholefield:fix-cmake

Conversation

@MatthewScholefield
Copy link
Contributor

This solves the following error that occurs when running cmake . -B build (no tests):

CMake Error at CMakeLists.txt:380 (set_property):
  Error evaluating generator expression:

    $<TARGET_FILE_NAME:bin2cpp_unittest>

  No target "bin2cpp_unittest"

Copy link
Owner

@end2endzone end2endzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thank you for pointing this one out. I always set this flag since I always needs to run unit tests but most users wont be in this position.

Regarding your change, I think lines 381 (from the original source code) should also be included in your new "if" block. The wix shortcut to generate_test_files.bat is used for generating unit test files and won't be generated either if you did not set option BIN2CPP_BUILD_TEST. It should be skipped as well.

If you do not want to make the change, I will take care of it myself. I am already glad that you contributed and found more issues and helped a lot.

If you do make changes, could you also do a force-push again to also include the latest changes from master to have all checks to run ?

@end2endzone end2endzone added the bug label Jun 5, 2021
@end2endzone end2endzone merged commit 454f841 into end2endzone:master Jun 6, 2021
end2endzone added a commit that referenced this pull request Jun 6, 2021
…hout unit tests.

Also disabled the same shortcuts in WIX installer.
For PR #45.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants