Remove LevEditType::Keep variant #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCondron
commented
Jan 21, 2023
Comment on lines
-514
to
+513
| let mut cur_op = LevEditType::Keep; | ||
| let mut cur_op = LevEditType::Replace; |
There was a problem hiding this comment.
This was the only change where I wasn't really sure on the semantics. Based on my reading of the code, the initial value of this variable doesn't really matter because it's always set on the first iteration of the following loop.
There was a problem hiding this comment.
Correct, initial value doesn't matter.
|
Thanks for the cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variant was left unused leading to dead match branches and unsound logic. I removed the variant and tried to tidy up
editops_from_cost_matrix. I think the code could be improved some more, but I wanted to stop here.