Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CONTRIBUTING.md) update wording and fix mistake #448

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

ArjunSharda
Copy link
Contributor

@ArjunSharda ArjunSharda commented Oct 17, 2022

I have made this PR for 3 key reasons:

  • Encore's Hacktoberfest
  • Wording used "the" and could be replaced with encore
  • Mistake with one link

@encore-cla
Copy link

encore-cla bot commented Oct 17, 2022

All committers have signed the CLA.

Copy link
Member

@eandre eandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArjunSharda, thanks for the submission! A few comments but otherwise LGTM.

@eandre eandre added the hacktoberfest For #Hacktoberfest (see https://hacktoberfest.com) label Oct 17, 2022
Copy link
Member

@eandre eandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DomBlack DomBlack merged commit 5812eee into encoredev:main Oct 19, 2022
@ArjunSharda ArjunSharda deleted the patch-1 branch October 19, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest For #Hacktoberfest (see https://hacktoberfest.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants