Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Prometheus remote-write exporter discards the response from
http.Do, so every metrics push leaks the response body and its connection. This change closes the response body. It also closes the response body infetchTemplates, the temporary config file handle ingit-remote-encore, the gzip writer when writing the wasm release artifact fails, and the gzip reader in the runtime config parser.Editor launches now call
Waitin the background so detached processes are reaped instead of remaining as zombies on Unix for the daemon's lifetime.Testing:
go build ./cli/cmd/encorego build ./cli/cmd/git-remote-encorego test ./cli/cmd/encore/app ./cli/cmd/git-remote-encore ./pkg/editors ./pkg/releaser/steps/tsparserwasmruntimes/go:go test ./appruntime/exported/config ./appruntime/infrasdk/metrics/prometheusI found these issues through a static analysis tool I'm developing called gohawk. If you're interested, let me know and I can open a separate PR to add gohawk to your linter configuration :) You can view more comprehensive information about the project on the documentation website: https://gohawk.dev
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.