tsparser validation improvements #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eandre
commented
Dec 10, 2024
eandre
commented
- Reapply "tsparser: improved app validation" (Revert "tsparser: improved app validation" #1633)
- tsparser: support validation in query/header/path
This reverts commit 7aca2b4.
|
All committers have signed the CLA. |
eandre
force-pushed
the
tsparser-validation-improvements
branch
from
f51d60e to
f015fdd
Compare
eandre
force-pushed
the
tsparser-validation-improvements
branch
from
f015fdd to
c9276da
Compare
fredr
reviewed
Dec 11, 2024
| @@ -326,6 +326,7 @@ func (db *Database) Begin(ctx context.Context) (*Tx, error) { | |||
| // this will be made with backwards compatibility in mind, providing ample notice and | |||
| // time to migrate in an opt-in fashion. | |||
| func Driver[T SupportedDrivers](db *Database) T { | |||
| db.init() | |||
There was a problem hiding this comment.
was this one meant to be part of this pr? no worries if it should be, just seemed a bit un-related
fredr
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.