Quality of Life improvements to local development dashboard #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the daemon to cache metadata for apps on the filesystem, this then allows the local dev dash to access this metadata without having to have the app running via `encore run`. This commit then tidies up a bunch of code around the dev dash API to standardise the status response allowing us to make much faster updates in the dev dash relating to the status of the app. Finnally I've added the ability for the dev dash to pass a correlation id to the daemon when it makes an api-call, allowing the dev dash to filter for logs relating to the request it made.
|
All committers have signed the CLA. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
eandre
reviewed
Jan 25, 2024
| name = filepath.Base(r.App.Root()) | ||
|
|
||
| // Load all the apps we know about | ||
| allApp, err := h.apps.List() |
There was a problem hiding this comment.
Do we ever delete from this list? Like if the user deletes the directory? We probably should
There was a problem hiding this comment.
Yes we do already do that:
// List lists all known apps.
func (mgr *Manager) List() ([]*Instance, error) {
roots, err := mgr.listRoots()
if err != nil {
return nil, err
}
var apps []*Instance
for _, root := range roots {
app, err := mgr.resolve(root)
if errors.Is(err, fs.ErrNotExist) {
log.Debug().Str("root", root).Msg("app no longer exists, skipping")
// Delete the
_, _ = mgr.db.Exec(`DELETE FROM app WHERE root = ?`, root)
continue
} else if err != nil {
log.Error().Err(err).Str("root", root).Msg("unable to resolve app")
continue
}
apps = append(apps, app)
}
return apps, nil
}
eandre
previously approved these changes
Jan 25, 2024
eandre
previously approved these changes
Jan 25, 2024
…ting where possible
DomBlack
force-pushed
the
enc-2019-support-app-offline-mode-for-dev-dash
branch
from
9ea1b14 to
c4be165
Compare
eandre
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to view all Encore apps via the local dashboard, regardless of if they are currently running or not, as well as several other UI improvements to the dashboard;
Offline apps are greyed out on lists, but can still be navigated
The API explorer now shows logs which were emitted during the API call
The dashboard now tells you when the app is compiling or just freshly restarted
Compile errors are now shown on the dashboard