Fix life cycle dependency appstore in api part 01 #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
reviewed
Jan 25, 2023
There was a problem hiding this comment.
Can you explain a bit more your changes and the plans how you would like to continue after this step? Some changes seem not that intuitive to me. :)
We do agree that in the end we can say it is fine that the stores depend on api, but not the other way around?
|
I apologize that it took me too long to reply to your comments.
Please let me know if I do bad code, I will fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our global
AppStoreandwebApiare used everywhere as desired, also inAccountApi,AssetsApi,ChainApiandCodecApi. This PR #525 (Fix cyclic dependency between store <> api) is the first step in solving the problem.AppStoreorwebApiare no longer used inAccountApi,AssetsApi,ChainApi.Yes some functions were moved into
Apibut this is temporarily. After merging this we will removeAppStorefromEncointerApiand then fromApi.