Support old and new reputation type #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…been linked to non-current cIndex
clangenb
added
A0-ux
clangenb
commented
Mar 19, 2024
| bool hasNewReputationType(RuntimeVersion version) { | ||
| Log.p('Runtime version ${version.toJson()}'); | ||
| if (version.specName == 'encointer-parachain') { | ||
| return version.specVersion >= 1002001; |
There was a problem hiding this comment.
@brenzi here I need your help. On latest master we have version 1002000 but on your pr we also have encointer/encointer-parachain#216 version 1002000, on rococo it is 1002001. Which spec version will be the one that has reputation v2 on Kusama?
There was a problem hiding this comment.
I had to bump spec version for rococo because the migration wouldn't be applied otherwise. I upgraded two RC's sequentially.
On kusama, 1002000 will be V2
On rococo, 1002000 was V1 1002001 is V2
As we will never see 1002000 on roc again, I think it is safe to assume
=1002000 => V2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The api infers the correct reputation type based on the runtime version's spec name and the spec version. If the chain doesn't support ReputationV2 yet, it will migrate fetched values to V2, where the linked index is going to be the current ceremony index. This essentially preserves the reputation v1 behavior, as any previously linked reputation can't be used again. Closes #1662.
Additionally, I regenerated the polkadart types, as it gave me the draft to use for the new reputation enum.
Tests: