Create and sign xts in dart #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ils. Probably because it can't understand the signed extensions
…insic param functions
clangenb
added
A2-technical
clangenb
commented
Jan 29, 2024
Comment on lines
-157
to
-160
| } else { | ||
| setState(() { | ||
| _transferState = TransferState.notStarted; | ||
| }); |
There was a problem hiding this comment.
This was unnecessary, we now change the state to submitting after checking the pin, this makes it easier.
| context, | ||
| store, | ||
| webApi, | ||
| store.account.getKeyringAccount(store.account.currentAccountPubKey!), |
There was a problem hiding this comment.
We now submit the signer, this will make it easier to implement #1469.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, we move the whole extrinsic creation process onto the dart side, and no JS is used anymore while sending extrinsics, closes #1540. However, it does not remove the webView yet, there is some minor clean up ahead: #1627
Relevant changes:
TxBuilder. This choice makes the extrinsic API much more flexible. For example, we can pass the signer from the outside instead of assuming it to be the current account, which makes Submit txs from non-current accounts #1469 a low-hanging fruit.