Improve PIN handling for creating and importing accounts #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
commented
Jan 19, 2024
Comment on lines
+36
to
+43
| /// Persists the new PIN in the secure storage. | ||
| /// | ||
| /// Attention: This function must be called *exclusively* upon: | ||
| /// * Setting the PIN initially | ||
| /// * Changing the PIN | ||
| Future<void> persistNewPin(String pin) async { | ||
| cachedPin = pin; | ||
| await loginService.setPin(pin); | ||
| await loginService.persistPin(pin); |
There was a problem hiding this comment.
I wanted this to be more expressive that this is a sensitive operation that should be used with caution.
clangenb
added
A1-bugfix
clangenb
changed the title
clangenb
changed the title
clangenb
deleted the
cl/profile-import-account-does-not-require-confirm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was about to investigate #1496, where I noticed that the account importing and the PIN querying was much more complicated and obfuscated than necessary (to be fair, parts of the simplifications were only possible after #1618).
Summary of changes:
NewAccountStoreto also query the pin, as it is not even needed anymore to create new accounts. Simply ask for the PIN if not cached on the Create/Import page. Closes account import fails at first attempt if PIN not cached #1496.setPinin cases where we only wanted to (runtime-)cache the PIN, butsetPinactually persists them to the secure storage. I removed all cases ofsetPINexcept for when actually setting the PIN or changing the PIN.