Catch exception during biometrics process and fallback to PIN dialog in this case. #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…delete keys explicitly
clangenb
commented
Dec 18, 2023
| @@ -50,7 +49,13 @@ final class LoginService { | |||
| await secureStorage.write(key: pinStorageKey, value: pin); | |||
| } | |||
|
|
|||
| Future<void> clearPin() => secureStorage.clear(); | |||
There was a problem hiding this comment.
This was dangerous, it clears the entire secure storage associated with the application. This was harmless now, as we don't store anything else currently, but later we intend to store the account seeds there too.
| Future<bool> localAuthenticate(String localizedReason, [bool stickyAuth = false]) { | ||
| try { | ||
| return localAuthentication.authenticate( | ||
| localizedReason: localizedReason, | ||
| options: AuthenticationOptions(useErrorDialogs: false, stickyAuth: stickyAuth), | ||
| ); | ||
| } catch (e, s) { | ||
| Log.e('$e', 'LoginStore', s); | ||
| return Future.value(false); |
There was a problem hiding this comment.
This might have been the reason that on some phones the authentication didn't work any more. We swallowed the exception, and returned false for authentication failed.
clangenb
added
A2-technical
clangenb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.