fix reputation count on profile page #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
commented
Dec 14, 2023
Comment on lines
-166
to
-168
| trailing: store.encointer.account?.reputations != null | ||
| ? Text(store.encointer.account?.reputations.length.toString() ?? 0.toString()) | ||
| : Text(l10n.fetchingReputations)), |
There was a problem hiding this comment.
Fetching reputation could never be reached anyhow, so I removed it.
clangenb
added
A1-bugfix
clangenb
force-pushed
the
cl/fix-reputation-count
branch
from
9bcfb2a
to
5a03863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error in how we computed the total reputation of an account, we included all kinds of reputation, which means that we accidentally included
UnverifiedReputable, which is wrong. We also know now that #1605 is not due to some lingering reputation, but simply wrong counting. Closes #1605. Tested locally that it works as intended.We should introduce check the actual reputation count in our integration tests as already described in #1599.